Split the AlphaVantage stock script into 2 scripts. One to make the API calls to AlphaVantage (this runs infrequently due to rate limit of free API keys) and saves the retrieved JSON files to cache. The other script can run more frequently and scans the cache dir for updated JSON files, and returns the formatted stock data to Conky.

conf

@@ -30,6 +30,7 @@
 --         chmod +x ~/.conky/mgconky/weather/parse_weather.sh
 --         chmod +x ~/.conky/mgconky/weather/parse_forecast.sh
 --         chmod +x ~/.conky/mgconky/stocks/get_stocks_alphavantage.py
+--         chmod +x ~/.conky/mgconky/stocks/process_stocks_alphavantage.py
 --         chmod +x ~/.conky/mgconky/stocks/get_stocks_finnhub.py
 --     (4) WEATHER.
 --         Make a free account at https://openweathermap.org/
@@ -178,7 +179,8 @@ ${voffset -6}${execpi 60 $HOME/.conky/mgconky/stocks/get_stocks_finnhub.py --api
 ${endif}
 # ***** Alpha Vantage API *****
 ${if_match "${template5}" != "YOUR_ALPHAVANTAGE_API_KEY_HERE"}
-${voffset -12}${execpi 43200 $HOME/.conky/mgconky/stocks/get_stocks_alphavantage.py --api_key ${template5} --symbols ${template7} --range_in_days 30 --price_dec_places 0 --percent_dec_places 1}
+${execpi 43200 $HOME/.conky/mgconky/stocks/get_stocks_alphavantage.py --api_key ${template5} --symbols ${template7} --range_in_days 30}
+${voffset -12}${execpi 60 $HOME/.conky/mgconky/stocks/process_stocks_alphavantage.py --symbols ${template7} --range_in_days 30 --price_dec_places 0 --percent_dec_places 1 --stale_seconds 43200}
 ${endif}
 #
 #--------------------------

stocks/get_stocks_alphavantage.py

@@ -3,16 +3,17 @@
 import os
 import sys
 import time
+import json
+import argparse
 import requests
 from datetime import datetime, timedelta
-import argparse
 
-CACHE_FILE = os.path.expanduser("~/.cache/mgconky/stocks_alphavantage.txt")
+CACHE_DIR = os.path.expanduser("~/.cache/mgconky/stocks_alphavantage/")
-API_DELAY_SECONDS = 15
+API_DELAY_SECONDS = 1
-USE_CACHE = True
+NO_THRASH_SECONDS = 60 * 60 # 1 hour
+
 
 def fetch_intraday_data(api_key, symbol, interval="1min"):
-    """Fetch current and historical intraday price using TIME_SERIES_INTRADAY."""
     url = "https://www.alphavantage.co/query"
     params = {
         "function": "TIME_SERIES_INTRADAY",
@@ -26,36 +27,26 @@ def fetch_intraday_data(api_key, symbol, interval="1min"):
             data = response.json()
             time_series = data.get(f"Time Series ({interval})")
 
-            # Debug: Log the raw response
-            #print(f"DEBUG: Response data for {symbol}: {data}")
-
             if time_series:
-                # Sort the timestamps to get the first (open) and latest price
                 sorted_timestamps = sorted(time_series.keys())
-                open_time = sorted_timestamps[0]  # Earliest timestamp of the day
+                open_time = sorted_timestamps[0]
-                latest_time = sorted_timestamps[-1]  # Most recent timestamp
+                latest_time = sorted_timestamps[-1]
-
-                # Extract open price and latest price
-                open_price = float(time_series[open_time]["1. open"])
-                latest_price = float(time_series[latest_time]["4. close"])
 
                 return {
-                    "current_price": latest_price,
+                    "current_price": float(time_series[latest_time]["4. close"]),
-                    "compare_price": open_price
+                    "compare_price": float(time_series[open_time]["1. open"]),
                 }
             else:
-                print(f"Error: No 'Time Series ({interval})' data found for {symbol}.")
+                print(f"Error: No 'Time Series ({interval})' data found for {symbol}.", file=sys.stderr)
-                return None
         else:
-            print(f"Error: Failed to fetch intraday data for {symbol} (HTTP {response.status_code})")
+            print(f"Error: Failed to fetch intraday data for {symbol} (HTTP {response.status_code})", file=sys.stderr)
-            return None
     except requests.RequestException as e:
-        print(f"Error: Failed to fetch intraday data for {symbol} - {e}")
+        print(f"Error: Failed to fetch intraday data for {symbol} - {e}", file=sys.stderr)
+
     return None
 
 
 def fetch_historical_data(api_key, symbol, range_in_days):
-    """Fetch current and historical price using TIME_SERIES_DAILY, allowing fallback to nearby dates."""
     url = "https://www.alphavantage.co/query"
     params = {
         "function": "TIME_SERIES_DAILY",
@@ -68,173 +59,91 @@ def fetch_historical_data(api_key, symbol, range_in_days):
             data = response.json()
             time_series = data.get("Time Series (Daily)")
 
-            # Debug: Log the raw response
-            #print(f"DEBUG: Response data for {symbol}: {data}")
-
             if time_series:
-                # Current price is the latest closing price
                 latest_date = max(time_series.keys())
-                latest_data = time_series[latest_date]
+                current_price = float(time_series[latest_date]["4. close"])
-                current_price = float(latest_data["4. close"])
 
-                # Dates to check: exact, one day before, one day after
+                target = datetime.now() - timedelta(days=range_in_days)
-                target_date = (datetime.now() - timedelta(days=range_in_days)).strftime("%Y-%m-%d")
-                fallback_dates = [
-                    target_date,
-                    (datetime.now() - timedelta(days=range_in_days + 1)).strftime("%Y-%m-%d"),
-                    (datetime.now() - timedelta(days=range_in_days - 1)).strftime("%Y-%m-%d")
-                ]
-
-                # Find the first available date in the fallback list
                 historical_price = None
-                for date in fallback_dates:
+                for offset in range(10):
-                    if date in time_series:
+                    d = (target - timedelta(days=offset)).strftime("%Y-%m-%d")
-                        historical_price = float(time_series[date]["4. close"])
+                    if d in time_series:
+                        historical_price = float(time_series[d]["4. close"])
                         break
 
                 return {
                     "current_price": current_price,
-                    "compare_price": historical_price
+                    "compare_price": historical_price,
                 }
             else:
-                print(f"Error: No 'Time Series (Daily)' data found for {symbol}.")
+                print(f"Error: No 'Time Series (Daily)' data found for {symbol}.", file=sys.stderr)
-                return None
         else:
-            print(f"Error: Failed to fetch historical data for {symbol} (HTTP {response.status_code})")
+            print(f"Error: Failed to fetch historical data for {symbol} (HTTP {response.status_code})", file=sys.stderr)
-            return None
     except requests.RequestException as e:
-        print(f"Error: Failed to fetch historical data for {symbol} - {e}")
+        print(f"Error: Failed to fetch historical data for {symbol} - {e}", file=sys.stderr)
+
     return None
 
 
 def main():
-    # Parse command-line arguments
+    parser = argparse.ArgumentParser()
-    parser = argparse.ArgumentParser(description="Fetch stock data from Alpha Vantage.")
+    parser.add_argument("--api_key", required=True)
-    parser.add_argument("--api_key", required=True, help="Your Alpha Vantage API key")
+    parser.add_argument("--symbols", required=True)
-    parser.add_argument("--symbols", required=True, help="Comma-separated list of stock symbols")
+    parser.add_argument("--range_in_days", type=int, default=0)
-    parser.add_argument("--range_in_days", type=int, default=0, help="Number of days for historical comparison (0 for none)")
-    parser.add_argument("--price_dec_places", type=int, default=0, help="Decimal places for prices")
-    parser.add_argument("--percent_dec_places", type=int, default=1, help="Decimal places for percentages")
     args = parser.parse_args()
 
-    # Split symbols
     symbols = args.symbols.strip().upper().split(",")
+    os.makedirs(CACHE_DIR, exist_ok=True)
 
-    # Use a list to build the final output string
-    output = []
-
-    # Prepare for printing output
-    color_header = "${color}"
-    color_label = "${color3}"
-    color_value = "${color3}"
-    color_good = "${color6}"
-    color_bad = "${color7}"
-    line_tab1_offset = "${goto 25}"
-    line_tab2_offset = "${goto 90}"
-    line_tab3_offset = "${alignr}" # Could also replace this with goto 120 if you don't like the right alignment
-
-    # Iterate symbols
-    had_success = False
     for i, symbol in enumerate(symbols):
-        fetched_data = fetch_intraday_data(args.api_key, symbol) if args.range_in_days < 1 else fetch_historical_data(args.api_key, symbol, args.range_in_days)
+        cache_path = os.path.join(CACHE_DIR, f"{symbol}.json")
+
+        # --- No-thrash protection ---
+        if os.path.exists(cache_path):
+            try:
+                with open(cache_path, "r") as f:
+                    payload = json.load(f)
+
+                if (
+                    isinstance(payload, dict)
+                    and "timestamp" in payload
+                    and isinstance(payload["timestamp"], (int, float))
+                    and (time.time() - payload["timestamp"]) < NO_THRASH_SECONDS
+                ):
+                    # Cache is recent enough ---> skip API call
+                    continue
+            except Exception:
+                # Any error ---> fall through and refetch
+                pass
+
+        fetched_data = (
+            fetch_intraday_data(args.api_key, symbol)
+            if args.range_in_days < 1
+            else fetch_historical_data(args.api_key, symbol, args.range_in_days)
+        )
+
         if (
             isinstance(fetched_data, dict)
             and "current_price" in fetched_data
             and isinstance(fetched_data["current_price"], (int, float))
         ):
-            had_success = True
+            tmp = os.path.join(CACHE_DIR, f"{symbol}.json.tmp")
-            current_price = fetched_data["current_price"]
+            final = os.path.join(CACHE_DIR, f"{symbol}.json")
-            compare_price = fetched_data["compare_price"]
+
-            price_difference = current_price - compare_price
+            payload = {
-            percent_change = (price_difference / current_price) * 100
+                "symbol": symbol,
-            color_dynamic = (
+                "range_in_days": args.range_in_days,
-                color_good if round(price_difference, args.price_dec_places) > 0 
+                "timestamp": int(time.time()),
-                else color_bad if round(price_difference, args.price_dec_places) < 0 
+                "data": fetched_data,
-                else color_value
+            }
-            )
+
-            output.append(
+            with open(tmp, "w") as f:
-                f"{line_tab1_offset}{color_label}{symbol}: {line_tab2_offset}{color_value}{round(current_price, args.price_dec_places):.{args.price_dec_places}f} "
+                json.dump(payload, f)
-                f"{line_tab3_offset}{color_dynamic}{round(price_difference, args.price_dec_places):+.{args.price_dec_places}f} "
+            os.replace(tmp, final)
-                f"({round(percent_change, args.percent_dec_places):+.{args.percent_dec_places}f}%)"
-            )
-        else:
-            output.append(f"{symbol}: Error fetching data")
 
-        # --- Rate limit protection for Alpha Vantage ---
         if i < len(symbols) - 1:
-            time.sleep(API_DELAY_SECONDS) # wait 15 seconds between queries
+            time.sleep(API_DELAY_SECONDS)
-
-    # Join all parts of the output and print it
-    header_label = f"Intraday" if args.range_in_days < 1 else f"{args.range_in_days} Day"
-    header_line = f"{line_tab1_offset}{color_header}Ticker{line_tab2_offset}Price ($$){line_tab3_offset}{header_label}{color_label}"
-    final_output = (
-        header_line
-        + "\n"
-        + f"{line_tab1_offset}{color_header}${{voffset -5}}${{hr 1}}"
-        + "\n"
-        + "\n".join(output)
-    )
-
-    if had_success:
-        if USE_CACHE:
-            # Save results to cache file
-            os.makedirs(os.path.dirname(CACHE_FILE), exist_ok=True)
-            tmp_file = CACHE_FILE + ".tmp"
-            with open(tmp_file, "w") as f:
-                f.write(final_output)
-            os.replace(tmp_file, CACHE_FILE)
-        else:
-            # Direct output mode (no cache)
-            return final_output
-    else:
-        # No valid data was returned
-        # Do NOT overwrite cache
-        # Do NOT return anything in cache mode
-        return None
-
 
 if __name__ == "__main__":
-
-    # The free alpha vantage plan may require you to rate limit.
-    # Conky will not wait for rate limited output.
-    # We must instead return the previous results
-    # (from when this script was last called)
-    # Set RATE_LIMIT to false if you have the paid plan.
-    if USE_CACHE:
-
-        # Fork immediately so the process Conky launched can exit right away.
-        pid = os.fork()
-        if pid > 0:
-            # PARENT PROCESS (this is the process Conky launched)
-
-            # Return contents of cache file (from early query to Conky)
-            if os.path.exists(CACHE_FILE):
-                try:
-                    with open(CACHE_FILE, "r") as f:
-                        print(f.read(), end="")
-                    sys.stdout.flush()
-                except Exception:
-                    pass
-
-            # Parent exits immediately ---> Conky renders output
-            sys.exit(0)
-
-        else:
-            # CHILD PROCESS (background updater, not waited on by Conky)
-
-            # Detach from the parent session so Conky does not wait on this process
-            os.setsid()
-
-            # Perform new query
     main()
-            sys.exit(0)
-
-    else:
-
-        # Return the results to Conky
-        result = main()
-        if result is not None:
-            print(result)
-
-
 

stocks/process_stocks_alphavantage.py

@@ -0,0 +1,133 @@
+#!/usr/bin/env python3
+
+import os
+import sys
+import time
+import json
+import argparse
+from datetime import datetime, timedelta
+
+CACHE_DIR = os.path.expanduser("~/.cache/mgconky/stocks_alphavantage/")
+
+def main():
+    # Parse command-line arguments (same shape as original, minus api_key)
+    parser = argparse.ArgumentParser(description="Process cached Alpha Vantage stock data.")
+    parser.add_argument("--symbols", required=True, help="Comma-separated list of stock symbols")
+    parser.add_argument("--range_in_days", type=int, default=0, help="Number of days for historical comparison")
+    parser.add_argument("--price_dec_places", type=int, default=0, help="Decimal places for prices")
+    parser.add_argument("--percent_dec_places", type=int, default=1, help="Decimal places for percentages")
+    parser.add_argument("--stale_seconds", type=int, default=13 * 3600, help="Seconds before cached data is considered stale")
+    args = parser.parse_args()
+
+    # Split symbols (unchanged)
+    symbols = args.symbols.strip().upper().split(",")
+
+    # Output builder (unchanged)
+    output = []
+
+    # Formatting (unchanged)
+    color_header = "${color}"
+    color_label = "${color3}"
+    color_value = "${color3}"
+    color_good = "${color6}"
+    color_bad = "${color7}"
+    line_tab1_offset = "${goto 25}"
+    line_tab2_offset = "${goto 90}"
+    line_tab3_offset = "${alignr}"
+
+    # Iterate symbols (structure preserved)
+    for symbol in symbols:
+        cache_path = os.path.join(CACHE_DIR, f"{symbol}.json")
+
+        # Missing cache file → invalid
+        if not os.path.exists(cache_path):
+            output.append(
+                f"{line_tab1_offset}{color_bad}{symbol}: "
+                f"{line_tab2_offset}{color_value}-- "
+                f"{line_tab3_offset}{color_value}-- (--%)"
+            )
+            continue
+
+        # Determine staleness from mtime
+        age_seconds = time.time() - os.stat(cache_path).st_mtime
+        symbol_color = color_bad if age_seconds > args.stale_seconds else color_label
+
+        # Load cached JSON
+        try:
+            with open(cache_path, "r") as f:
+                payload = json.load(f)
+            if not isinstance(payload, dict) or "data" not in payload:
+                raise ValueError("Invalid cache payload")
+            fetched_data = payload["data"]
+
+        except Exception:
+            output.append(
+                f"{line_tab1_offset}{color_bad}{symbol}: "
+                f"{line_tab2_offset}{color_value}-- "
+                f"{line_tab3_offset}{color_value}-- (--%)"
+            )
+            continue
+
+        # ------------------------------
+        # VALIDATION
+        # ------------------------------
+        if (
+            isinstance(fetched_data, dict)
+            and "current_price" in fetched_data
+            and isinstance(fetched_data["current_price"], (int, float))
+        ):
+            current_price = fetched_data["current_price"]
+            compare_price = fetched_data["compare_price"]
+
+            # Defensive: compare_price may still be None
+            if not isinstance(compare_price, (int, float)):
+                symbol_color = color_bad
+                output.append(
+                    f"{line_tab1_offset}{symbol_color}{symbol}: "
+                    f"{line_tab2_offset}{color_value}-- "
+                    f"{line_tab3_offset}{color_value}-- (--%)"
+                )
+                continue
+
+            price_difference = current_price - compare_price
+            percent_change = (price_difference / current_price) * 100
+
+            color_dynamic = (
+                color_good if round(price_difference, args.price_dec_places) > 0
+                else color_bad if round(price_difference, args.price_dec_places) < 0
+                else color_value
+            )
+
+            output.append(
+                f"{line_tab1_offset}{symbol_color}{symbol}: "
+                f"{line_tab2_offset}{color_value}{round(current_price, args.price_dec_places):.{args.price_dec_places}f} "
+                f"{line_tab3_offset}{color_dynamic}{round(price_difference, args.price_dec_places):+.{args.price_dec_places}f} "
+                f"({round(percent_change, args.percent_dec_places):+.{args.percent_dec_places}f}%)"
+            )
+        else:
+            # Invalid cached data → treat as bad/stale
+            output.append(
+                f"{line_tab1_offset}{color_bad}{symbol}: "
+                f"{line_tab2_offset}{color_value}-- "
+                f"{line_tab3_offset}{color_value}-- (--%)"
+            )
+
+    # Header (unchanged naming)
+    header_label = "Intraday" if args.range_in_days < 1 else f"{args.range_in_days} Day"
+    header_line = (
+        f"{line_tab1_offset}{color_header}Ticker"
+        f"{line_tab2_offset}Price ($$)"
+        f"{line_tab3_offset}{header_label}{color_label}"
+    )
+
+    print(
+        header_line
+        + "\n"
+        + f"{line_tab1_offset}{color_header}${{voffset -5}}${{hr 1}}"
+        + "\n"
+        + "\n".join(output)
+    )
+
+if __name__ == "__main__":
+    main()
+